How To Display Newer Comments First The comments view doesn't currently know anything about whether a comment is outdated (a github pr concept) and there's no way with the existing api to sufficiently show that a comment is outdated. With the switch to modern comments, we are now having an issue where a long comment only shows the first three lines of a comment and you have to "click into" the comment in order to see the full text. however, there is no indication that the comment might be longer.
Managing Comments On Preview Deployments On github, after opening the link of a pull request, the review comments on commits older than the current commit are hided, because they are outdated. i have to click "show outdated" for each such comments to see them. I don't see a nice way to enable clicking on the comment thread to open a diff. currently, clicking on the comment thread opens the resource that the comment applies to. That outdated comments have an inline action in the "comments" view to "diff comment with head". this action should also be in the context menu. verify that this action does what you'd expect. lgtm on windows! yes i can, works well. Currently in the comments panel there is an option to filter comments by "show resolved" and "show unresolved". it would be great if there was an option to filter outdated comments ("show outdated") as well.
Github Crayon8898 Outdated Comment Detection The Replication Package That outdated comments have an inline action in the "comments" view to "diff comment with head". this action should also be in the context menu. verify that this action does what you'd expect. lgtm on windows! yes i can, works well. Currently in the comments panel there is an option to filter comments by "show resolved" and "show unresolved". it would be great if there was an option to filter outdated comments ("show outdated") as well. Github comments on specific lines or sections of a file are associated with a specific commit. when you push changes to a repository, github creates a new commit for those changes. even if the changes are made in a different file, the commit hash is different. We know this occurs if the comment goes "outdated" due to code changes, but this is not happening in this case the comment simply disappears without trace, with no further code changes. A colleague has updated the code to apply my suggested changes, and now all my review comments appear with the outdated label. however i still see the code in the state it was when i commented it. If a comment is off topic, outdated, or resolved, you may want to hide a comment to keep a discussion focused or make a pull request easier to navigate and review.
Comments are closed.